Conversation
Paradoxis
left a comment
Paradoxis
left a comment
There was a problem hiding this comment.
Nice module, consider adding the two extra installation paths and other than that looks good to me
| "/etc/tomcat*", # Handles symlinked conf folders (e.g. /var/lib/tomcat10/conf -> /etc/tomcat10) | ||
| "/usr/local/tomcat*", | ||
| "/opt/bitnami/tomcat*", | ||
| "/opt/tomcat*", |
There was a problem hiding this comment.
Consider adding:
/usr/share/tomcat*/usr/share/tomcat*-root
https://askubuntu.com/questions/135824/what-is-the-tomcat-installation-directory
| self.log_files = list(self.find_log_files()) | ||
|
|
||
| def check_compatible(self) -> None: | ||
| if not self.installs and not self.configs and not self.log_files: |
There was a problem hiding this comment.
That's fine for this method.
| from dissect.target.target import Target | ||
|
|
||
|
|
||
| def test_unix_logs_default_install(target_unix: Target, fs_unix: VirtualFilesystem) -> None: |
There was a problem hiding this comment.
Don't forget to add a test case for the other installation path from the previous comment
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 81.11% 81.09% -0.02%
==========================================
Files 402 403 +1
Lines 35244 35408 +164
==========================================
+ Hits 28587 28713 +126
- Misses 6657 6695 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3 participants
This PR adds a generic plugin for Apache Tomcat.